Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject: Communication Issue Between Viz and External Prometheus #1659

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JadKHaddad
Copy link

Problem: In the documentation explaining the usage of an external Prometheus, the protocol is missing in provided example. This is causing Viz to be unable to establish communication with the external Prometheus, resulting in a "unsupported protocol" error message in the logs.

Solution: added protocol and basic auth to prometheus url

Fixes #1658

JadKHaddad and others added 2 commits August 20, 2023 13:52
Problem: In the documentation explaining the usage of an external Prometheus, the protocol is missing in provided example. This is causing Viz to be unable to establish communication with the external Prometheus, resulting in a "unsupported protocol" error message in the logs.

Solution: added protocol and basic auth to prometheus url

Fixes linkerd#1658

Signed-off-by: JadKHaddad <[email protected]>
@wmorgan wmorgan requested a review from kflynn October 11, 2023 17:17
@kflynn
Copy link
Member

kflynn commented Nov 1, 2023

@JadKHaddad, many thanks! and many apologies for letting this linger. 🤦‍♂️ This looks nice! I've updated this to the latest main, but I have two other requests:

  1. Can you also show an example without the username and password? presumably it's not always necessary.
  2. Can you copy this into the 2.14 directory, too?

Thank you! and, again, I'm sorry for the delay.

@JadKHaddad
Copy link
Author

@kflynn I'm worried about the heartbeat because it only looks for a Prometheus job called kubernetes-nodes-cadvisor If someone's using a different job name, like cadvisor, it won't work. Should we add the job to the docs?

@kflynn
Copy link
Member

kflynn commented Nov 13, 2023

The example you added looks great, thanks! I think adding the job also sounds like a great idea.

@kflynn
Copy link
Member

kflynn commented Nov 13, 2023

Oh, whoops – any chance you can fix the DCO for your latest, too? 😅

@JadKHaddad
Copy link
Author

whoops :P

Before adding the job to the docs, I want to test the entire workflow again on a fresh Kubernetes cluster. My latest tests were with Linkerd v2.13.

@kflynn
Copy link
Member

kflynn commented Dec 1, 2023

@JadKHaddad Any joy? 🙂

@JadKHaddad
Copy link
Author

Hi @kflynn. In version stable-2.14.5, which I'm currently using, the PrometheusUrl appears to be hardcoded (see values).

In contrast, on the main branch, it is variable and can be specified through the control-plane Helm chart (see values).

We can provide all sorts of workarounds in the documentation, like deploying a named service in k8s, but I think this is not what we want to do. Optimally, we wait for the new release which should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks - Bringing your own Prometheus - Protocol is missing in external Prometheus URL
3 participants