Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to latest Hugo version #1689

Merged
merged 12 commits into from
Oct 2, 2023
Merged

Upgraded to latest Hugo version #1689

merged 12 commits into from
Oct 2, 2023

Conversation

travisbeckham
Copy link
Collaborator

  • Updated .URL to .RelPermalink
  • Switched from Blackfriday to Goldmark markdown renderer
  • Fixed tweet shortcode
  • Fixed highlighting in main nav
  • Set Hugo version to 0.119.0

Signed-off-by: Travis Beckham <[email protected]>
@travisbeckham
Copy link
Collaborator Author

travisbeckham commented Sep 27, 2023

Note to reviewers:

  • The http://linkerd.io/2/... redirect to the latest version is not working in the preview. However, that never works locally for me. Not sure how to test that I didn’t break that functionality.

  • One of the jobs failed because it can’t find the Hugo config file. That config file was renamed as part of the upgrade. I'm assuming the website-builder container is still using the old Hugo version. If so, how can I get website-builder:v1.3.3 to use Hugo 0.119.0?

Things that have changed

@wmorgan
Copy link
Member

wmorgan commented Sep 28, 2023

Thank you for tackling this. You've exposed a problem with our build process which still relies on an ancient website-builder image which contains hugo 0.61. It looks like the Dockerfile that builds this image was removed by @olix0r in 38187d1. I'll discuss with him what the most expedient path is going forward.

@wmorgan
Copy link
Member

wmorgan commented Sep 29, 2023

The most expedient path forward is to revive the Dockerfile and build a new image of website-builder with an updated version of Hugo.

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for doing this!! Let's get this landed. 🙂

@travisbeckham travisbeckham merged commit 1254bbe into main Oct 2, 2023
12 checks passed
@travisbeckham travisbeckham deleted the travis/upgrade-hugo branch October 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants