Removed nominated heroes, linked to blog for voted heroes #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
|
Based on feedback, I merged the nominated heroes into the same list as the voted heroes. I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently missing a content header on the Heroes page. We have 2 sections: voted and nominated, and they run together without anything separating them. Since we haven't added nominated heroes since 2021, we should remove them.
For voted heroes, instead of linking to their Github or Linkedin page, we should link to the blog, if it available.
With this PR, I have removed the nominated heros, and updated the links to point to the blog post for voted heroes. If a blog post wasn't made for a hero, then the existing Github or Linkedin url is used.
I also checked to see if every hero blog post had a link to the hero's Github or Linkedin page, and added it if needed. The one exception is the blog post for Dom DePasquale. The Github page we have for him returns a 404, and I can't find his Github or Linkedin page.