Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension is not working with SSO #45

Open
cycomanic opened this issue Dec 29, 2023 · 13 comments
Open

extension is not working with SSO #45

cycomanic opened this issue Dec 29, 2023 · 13 comments

Comments

@cycomanic
Copy link

The extension is not working with SSO (oauth2) at the moment. No rush (I know oauth2 just landed), just wanted to document it here.

@crkos
Copy link
Member

crkos commented Jan 8, 2024

Hello, I just pushed into dev a version that fixes this, If you can install it in your browser and let me know if it's working for you that would be great!

@crkos
Copy link
Member

crkos commented Jan 8, 2024

Make sure to check the new options on the Config window on the extension

@apo2k7
Copy link

apo2k7 commented Jan 11, 2024

Hi! Thank you for adding the SSO login feature. I tried it with the Brave browser. Worked perfectly!

@laxmanpradhan
Copy link

any chance this version could be pushed to the firefox add-on store? Thanks!

https://addons.mozilla.org/en-US/firefox/addon/linkwarden/

@crkos
Copy link
Member

crkos commented Jan 12, 2024

Hello, I'm currently working on an OpenAPI specification of the API for linkwarden, I haven't tested this for firefox which will be definitly not work, because i havent modified the manifest and i'm not sure some browser apis i'm using work with firefox and V2 extensions, until i havent done that, i can't upload to the store, However it will be done soon. Worst case i have to mantain two versions of this.

@alceasan
Copy link

I could help with testing if there is any available build to install.

@crkos
Copy link
Member

crkos commented Jan 15, 2024

If you have npm you can compile it
with npm run build then do as the readme says, just install the folder name dist

@chrisbsmith
Copy link

chrisbsmith commented Jan 16, 2024

This worked for me (thanks!), but I got a warning that I needed to supply a username/password even with the Use SSO checkbox checked. I used my username name, but a dummy value for the password. Auth worked and I'm able to save links, so just some small UI/UX things to work out.

@crkos
Copy link
Member

crkos commented Jan 16, 2024

Yeah thats actually something i was thinking about, since it will shift the content every time you would click on it (or just make them not required), I just leave it there, but if you prefer like that i can just render it based on that, I actually doesnt matter if you provide username/password when SSO is checked is just UI validation nothing is sent to the server othen than checking if there is a session active.

@crkos
Copy link
Member

crkos commented Jan 16, 2024

Currently i dont have much time to work on it, Whats left to jump to next version is working the firefox (manifest v2...) version, it shouldn't take much effort is just modifying the manifest and a few things, It will be soon on the stores to just add it to browser, also a few features are already in, such as omnibox, context right click to add the page and automatic sync even if you dont add from the extension but the local bookmark it will be added to linkwarden

@chrisbsmith
Copy link

Yeah thats actually something i was thinking about, since it will shift the content every time you would click on it (or just make them not required), I just leave it there, but if you prefer like that i can just render it based on that, I actually doesnt matter if you provide username/password when SSO is checked is just UI validation nothing is sent to the server othen than checking if there is a session active.

I agree with your thoughts, but when I tried to auth with SSO checked, the validation failed that the username/password boxes were not populated.

@crkos
Copy link
Member

crkos commented Jan 17, 2024

Yes that is intented to happen, Even though not needed

@crkos
Copy link
Member

crkos commented Jan 17, 2024

I will probably remove it in the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants