Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert - Potential use after free #2203

Open
1 task
igaw opened this issue Feb 2, 2024 · 5 comments
Open
1 task

Fix code scanning alert - Potential use after free #2203

igaw opened this issue Feb 2, 2024 · 5 comments
Labels
wait-on-upstream Upstream needs to do something

Comments

@igaw
Copy link
Collaborator

igaw commented Feb 2, 2024

CodeQL complains about a UAF:

Memory may have been previously freed by  


ccan/ccan/strset/strset.c:196
			}

			/* Sew empty string back so remaining logic works */
			free(n->u.n);
			n->u.s = empty_str;
			break;
		}


if (!streq(member, n->u.s)) {

Tracking issue for:

@igaw igaw changed the title potential use after free Fix code scanning alert - Potential use after free Feb 2, 2024
@igaw
Copy link
Collaborator Author

igaw commented Jul 12, 2024

Maybe we should just merge your fix. Upstream is not really responding. We did it the same for the include/define fix for bigendian too.

@igaw igaw added the wait-on-upstream Upstream needs to do something label Jul 12, 2024
@ikegami-t
Copy link
Contributor

Thank you. Noted.

@ikegami-t
Copy link
Contributor

So can we close the issue now?

@igaw
Copy link
Collaborator Author

igaw commented Jul 25, 2024

Let's keep it open to track upstream. I still hope it gets eventually addressed.

@ikegami-t
Copy link
Contributor

I see. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-on-upstream Upstream needs to do something
Projects
None yet
Development

No branches or pull requests

2 participants