Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPMTOTP HOTP code to be extended to 40 bytes (vs 20) #1437

Open
tlaurion opened this issue Jul 10, 2023 · 0 comments
Open

TPMTOTP HOTP code to be extended to 40 bytes (vs 20) #1437

tlaurion opened this issue Jul 10, 2023 · 0 comments

Comments

@tlaurion
Copy link
Collaborator

tlaurion commented Jul 10, 2023

This is to track changes needed inside tpmtotp so that secret can be extended to use full 40 bytes available in HOTP in firmware


@tlaurion Firmware supports it per your notes, but hotp from tpmtotp still requires exactly 20 bytes: https://github.com/osresearch/tpmtotp/blob/master/hotp.c#L26

The secret does not have to be printable, so I can use 20 binary bytes from the hash and get 160 bits of entropy, up from 80 currently (20 hex chars).

tpmtotp can be extended but I feel like this is going down a rabbit hole to go from 160 bits to 256 bits. Can we track that for an improvement later?

Originally posted by @JonathonHall-Purism in #1419 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant