Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monitor multitask status signal #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zy-seven
Copy link

monitor multitask status signal

Log: monitor multitask status signal

Bug: https://pms.uniontech.com/bug-view-275171.html

monitor multitask status signal

Log: monitor multitask status signal

Bug: https://pms.uniontech.com/bug-view-275171.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DeepinWMFaker::SlotUpdateMultitaskStatus函数中,m_isMultitaskingActived变量应该使用this指针来访问类的成员变量,而不是直接使用局部变量isActive
  • DeepinWMFaker::SlotUpdateMultitaskStatus函数缺少注释说明其用途和功能。
  • DeepinWMFaker::GetIsShowDesktop函数的返回类型是bool,但是函数体内没有对m_isShowDesktop变量的类型进行检查,可能会导致未定义行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zy-seven

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants