Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dbus window visible property and changed signal #167

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

yixinshark
Copy link
Contributor

dock-clipboard plugin need clipboard window's visible property.

Log: as title
Influence: dbus has visible property

dock-clipboard plugin need clipboard window's visible property.

Log: as title
Influence: dbus has visible property
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::paintEvent中,p.drawRoundedRect的调用应该在p.setPen之后,以避免出现没有边框的圆角矩形。
  • MainWindow::showEventMainWindow::hideEvent中调用了Q_EMIT来发送信号,但没有传递任何参数。如果这些信号需要参数,应该使用emit方法。
  • MainWindow::clipboardVisible私有槽函数直接返回isVisible(),这可能不是预期的行为,因为它返回的是窗口的可见性状态,而不是剪贴板是否可见。
  • MainWindow类中的clipboardVisible私有槽函数和clipboardVisibleChanged信号可能需要更明确的命名,以反映它们与剪贴板相关的功能。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit f5c0afd into linuxdeepin:master Jul 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants