Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window removes its own display animation #170

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

yixinshark
Copy link
Contributor

as title

Log: as title
Issue: linuxdeepin/developer-center#9728

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CompositeChanged函数中硬编码了m_hasComposite的值为false,这可能会影响窗口的显示效果。
  • 注释“// 屏蔽应用自己的动画,默认使用窗管窗口显示动画”表明有特定的设计意图,但这个更改可能会影响用户体验。

是否建议立即修改:

  • 是,需要确认这个更改是否符合设计要求,并确保它不会对用户体验产生负面影响。如果这个更改是故意的,应该添加相应的注释说明原因,以便其他开发者理解这一变更。如果这是一个错误,应该恢复原来的代码,并评估是否有其他更好的解决方案。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xionglinlin, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 678d37f into linuxdeepin:master Aug 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants