Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: highlight not visible when focus in #35

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: highlight not visible when focus in #35

merged 2 commits into from
Jan 5, 2024

Conversation

asterwyx
Copy link
Contributor

@asterwyx asterwyx commented Jan 5, 2024

Always scroll to the highlight when focus in.

Log: fix highlight not visible when focus in
Issue: linuxdeepin/developer-center#6397

@asterwyx asterwyx requested a review from BLumia January 5, 2024 02:33
@asterwyx asterwyx added the bug Something isn't working label Jan 5, 2024
@asterwyx asterwyx assigned BLumia and asterwyx and unassigned BLumia Jan 5, 2024
@asterwyx
Copy link
Contributor Author

asterwyx commented Jan 5, 2024

/integrate

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#887
PrNumber: 887
PrBranch: auto-integration-7417343826

@deepin-community-ci-bot deepin-community-ci-bot bot mentioned this pull request Jan 5, 2024
Closed
BLumia
BLumia requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations 目录就不用带进来了吧？

@asterwyx
Copy link
Contributor Author

asterwyx commented Jan 5, 2024

翻译是单独的一个commit的，是不是应该让lupdate之后的内容生成在build目录下？不然的话每次cmake run之后都会有ts文件的更新。

@asterwyx
fix: highlight not visible when focus in
563d472 
Always scroll to the highlight when focus in.

Log: fix highlight not visible when focus in
Issue: linuxdeepin/developer-center#6397
@asterwyx
chore: update translations
c649431 
Update translations.

Log: update translations
@BLumia
Copy link
Member

BLumia commented Jan 5, 2024

翻译是单独的一个commit的，是不是应该让lupdate之后的内容生成在build目录下？不然的话每次cmake run之后都会有ts文件的更新。

Qt 5 那个翻译更新相关的 CMake macro 是每次源码有变化都会重新生成翻译的。Qt 6 废弃了旧的那个 macro 并提供了一个新的，新的会单独提供一个用于生成翻译的 target。dde-launchpad 放弃支持 Qt 5 版本后会换掉那个新的 CMake macro，就不会每次都会更新翻译了。

BLumia
BLumia approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

算了反正不影响，不等了。合入后打 tag。打完 tag 后 drop Qt 5 支持。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
Copy link
Member

BLumia commented Jan 5, 2024

/merge

@deepin-bot deepin-bot bot merged commit ad5d023 into linuxdeepin:master Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia approved these changes

Assignees

@asterwyx asterwyx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asterwyx @BLumia @deepin-ci-robot