Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to switch pages by clicking indicator button #417

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

FeiWang1119
Copy link
Contributor

if the property is later assigned a static value from a JavaScript statement, the binding will be removed.
If you need to assign, please rebind the property after assigning.

Issue: https://pms.uniontech.com/bug-view-272715.html

@deepin-bot
Copy link

deepin-bot bot commented Sep 9, 2024

TAG Bot

New tag: 1.0.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #416

xionglinlin
xionglinlin previously approved these changes Sep 9, 2024
if the property is later assigned a static value from a JavaScript statement, the binding will be removed.
If you need to assign, please rebind the property after assigning.

Issue: https://pms.uniontech.com/bug-view-272715.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setCurrentIndex函数中,直接修改了listviewPage.currentIndex的值,这可能会导致与预期行为不符的问题。建议使用listviewPage.currentIndex = index来设置当前索引。
  • setCurrentIndex函数中的两个赋值操作符可能会导致混淆,建议将它们分开为两个函数,以提高代码的可读性。
  • Keys.onLeftPressedKeys.onRightPressed函数中,setCurrentIndex函数被重复调用,但没有考虑到itemPageModel.rowCount()可能为0的情况,可能会导致运行时错误。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, FeiWang1119, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 522fd3a into linuxdeepin:release/beige Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants