Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various issue after initial port to dde-shell #428

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Sep 23, 2024

修复多个初版移植到 dde-shell 后引入的问题,包括:

  • liblaunchpad 未安装(追加 install 并更改 target 名称)
  • 全屏启动器无模糊版背景(补充注册 imageprovider)
  • 全屏启动器上下滚轮无法翻页(补充缺失的辅助函数)
  • 优化x11下全屏模糊背景的速度与内存占用(减小图片 sourcesize)

Log:

修复多个初版移植到 dde-shell 后引入的问题,包括:

- liblaunchpad 未安装(追加 install 并更改 target 名称)
- 全屏启动器无模糊版背景(补充注册 imageprovider)
- 全屏启动器上下滚轮无法翻页(补充缺失的辅助函数)
- 优化x11下全屏模糊背景的速度与内存占用(减小图片 sourcesize)

Log:
@BLumia BLumia requested a review from tsic404 September 23, 2024 10:16
@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@BLumia BLumia marked this pull request as ready for review September 23, 2024 10:16
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • launcheritem.cpp中添加了DS_USE_NAMESPACE宏的使用,但未提供上下文说明其用途。
  • launcheritem.cpp中添加了QML引擎的图片提供者,但没有提供添加这些提供者的原因和上下文。
  • decrementPageIndexincrementPageIndex函数在launcheritem.qml中新增,但没有提供这些函数的实现细节和用途。
  • launcheritem.qml中新增了closeContextMenu函数,但没有提供其实现细节和用途。

是否建议立即修改:

  • 是,建议添加必要的注释和文档,以便其他开发者理解这些更改的目的和上下文。特别是对于新增的函数和宏,应该提供清晰的文档说明其用途和工作原理。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit d9f1dae into linuxdeepin:master Sep 24, 2024
9 of 10 checks passed
@BLumia BLumia deleted the shell-misc branch September 24, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants