Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update controller visible state when windowed frame focus out #430

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Sep 24, 2024

当小窗口启动器的 Popup 被隐藏时,更新 LauncherController 的状态,避免
下次按下 Meta 或点击启动器图标时无法使启动器重新显示出来。

Log:

当小窗口启动器的 Popup 被隐藏时,更新 LauncherController 的状态,避免
下次按下 Meta 或点击启动器图标时无法使启动器重新显示出来。

Log:
@BLumia BLumia requested a review from tsic404 September 24, 2024 11:44
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • onPopupVisibleChanged函数中,应该检查LauncherController.currentFrame是否为"WindowedFrame",然后再执行其他操作,以避免不必要的重复检查。
  • popupVisible变量在函数中被使用,但没有在函数内部定义,可能是一个未声明的变量。
  • 函数onPopupVisibleChanged中的逻辑可能需要更详细的错误处理,例如当LauncherController.visible的设置失败时。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit ce005d0 into linuxdeepin:master Sep 24, 2024
9 of 10 checks passed
@BLumia BLumia deleted the popup-visible branch September 24, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants