Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API to check if a package is dummy package #432

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Sep 25, 2024

支持使用 AppStream 的自定义字段(DDE:is_dummy_package)声明虚拟占位包。

暂时没有 UI 实现,UI 相关的行为放到另外的提交中做。

Log:

支持使用 AppStream 的自定义字段(DDE:is_dummy_package)声明虚拟占位包。

Log:
@BLumia BLumia requested a review from tsic404 September 25, 2024 09:30
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • appIsDummyPackage函数中,Q_UNUSED(desktopId)宏的使用可能是多余的,除非有特定的理由需要保留这个参数但不在当前函数中使用。
  • appIsDummyPackage函数中没有处理pool.load()可能抛出的异常,这可能会导致未处理的初始化错误。
  • appIsDummyPackage函数中的注释// qDebug() << pool.flags();表明可能存在调试代码,应该确认是否需要在提交代码中保留。
  • appIsDummyPackage函数中的循环使用了AppStream::Component的迭代器,但没有对迭代器进行有效性检查,可能会导致未定义的行为。
  • appIsDummyPackage函数的返回类型是bool,但是在函数体内没有对返回值进行任何处理或检查,这可能意味着函数的返回值没有实际的意义。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit b976ebd into linuxdeepin:master Sep 27, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants