Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid hover animation for grid items #435

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Oct 8, 2024

避免 hover 时由 ToolButton 导致的放大动效。

Log:

避免 hover 时由 ToolButton 导致的放大动效。

Log:
@BLumia BLumia requested a review from tsic404 October 8, 2024 11:51
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FullscreenFrame.qml中新增了WindowedLaunchpad模块的引用,但未提供该模块的详细信息,可能需要确认是否已定义。
  • IconItemDelegate.qml中,将contentItemToolButton更改为Button,并设置了flat属性为true,这可能影响按钮的视觉效果和交互。
  • IconItemDelegate.qml中,新增了ColorSelector.family属性的设置,但未提供该属性的具体作用和上下文。
  • windowed/IconItemDelegate.qml中,与IconItemDelegate.qml的修改类似,但未提供修改的上下文和原因。

是否建议立即修改:

  • 是,需要确认新增的模块WindowedLaunchpad是否已定义,并确保修改后的代码不会影响应用程序的正常功能。同时,需要提供更多上下文信息,以便其他开发者理解这些更改的目的。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 90bdc15 into linuxdeepin:master Oct 10, 2024
7 of 10 checks passed
@BLumia BLumia deleted the hover branch October 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants