Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): error appid from getAppIdFromAbsolutePath #435

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Groveer
Copy link
Contributor

@Groveer Groveer commented Aug 27, 2024

Log: tmp变量读出来的字符串多带了一个字符

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Aug 27, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#435
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Log: tmp变量读出来的字符串多带了一个字符
@kegechen kegechen merged commit 280791d into linuxdeepin:master Sep 9, 2024
3 checks passed
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Sep 9, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#435
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • path.chopped(desktopSuffix.size() - 1) 修改为 path.chopped(desktopSuffix.size()) 可能会导致路径截取不完整,需要确认是否符合预期。
  • 检查 desktopSuffix 的定义和大小,确保 path.chopped(desktopSuffix.size()) 不会导致路径截取错误。

是否建议立即修改:

  • 是,需要确保修改后的代码不会引入新的错误,并且与原有的逻辑一致。

kegechen pushed a commit to linuxdeepin/dtk6core that referenced this pull request Sep 9, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#435
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 9, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants