Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old tags are wrong #333

Open
1 task done
ngosang opened this issue May 2, 2024 · 4 comments
Open
1 task done

Old tags are wrong #333

ngosang opened this issue May 2, 2024 · 4 comments
Labels
work-in-progress Stale exempt

Comments

@ngosang
Copy link

ngosang commented May 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

There are old tags with higher number than the latest releases => v1.0.20210914-ls99
This causes confusion in docker updaters like diun / whatsupdocker. You should bump the ls99 part to a higher number

image

Expected Behavior

No response

Steps To Reproduce

.

Environment

.

CPU architecture

x86-64

Docker creation

.

Container logs

.
Copy link

github-actions bot commented May 2, 2024

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@ngosang ngosang changed the title Old tags Old tags are wrong May 2, 2024
@drizuid drizuid added the work-in-progress Stale exempt label May 2, 2024
@Roxedus
Copy link
Member

Roxedus commented May 2, 2024

While we think on this, its worth mentioning the lsxxx number did indeed restart, but it did not stop at 99, it went to 126. While our logic has some inconsistencies here, the detection you posted also isnt flawless.
image

@ngosang
Copy link
Author

ngosang commented May 2, 2024

Yeah, I have a regular expression with just 2 digits. It will be fine if we continue in 127

@aptalca
Copy link
Member

aptalca commented May 2, 2024

To provide more context, we use skopeo to retrieve the last pushed version for the branch tag and extract the ls version to decide on the new tag.

Every once in a while it fails and starts from 1. Normally that's not an issue as the versions get bumped and there is no overlap. But wireguard tools did not get a version update in 3 years, and it led to overlap of tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale exempt
Projects
Status: Issues
Development

No branches or pull requests

4 participants