Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic deployment for PRs #105

Closed
alifeee opened this issue Aug 26, 2024 · 3 comments
Closed

automatic deployment for PRs #105

alifeee opened this issue Aug 26, 2024 · 3 comments
Assignees

Comments

@alifeee
Copy link
Member

alifeee commented Aug 26, 2024

it nearly works

it works fine on this repository (on the staging-deployment-works-internally tag) for internal PRs

it does not work yet for pull requests from forks, as these are funky

I need to set this up actions/checkout#518 (comment) so that an action can both

  • use the code from the forked PR (with pull_request event)
  • use the secrets from this repository (with pull_request_target event)

(this is not something that github actions likes you doing)

alternatively, I could just tell forks that they should create their own secrets for surge and it will work for them

also, the surge step doesn't fail if the ENV variables SURGE_LOGIN and SURGE_KEY are unset. It should, then it would be obvious that it fails.

This sounds like a good compromise, and the action could report the URL in the same way that github pages reports the URL as an output

@alifeee alifeee self-assigned this Aug 26, 2024
@alifeee
Copy link
Member Author

alifeee commented Aug 26, 2024

could write surge description in a contirbuting guide

@lipu-tenpo lipu-tenpo deleted a comment from Saschl Aug 26, 2024
@alifeee
Copy link
Member Author

alifeee commented Aug 26, 2024

done, final commit is in 5ee5ff9

@alifeee alifeee closed this as completed Aug 26, 2024
@alifeee
Copy link
Member Author

alifeee commented Aug 26, 2024

it just uses comments, not deployments, because there is no ref to use if the pull request comes from a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant