Improve declarative usage of authentication module #2766
+314
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/build |
claudiolor
changed the title
|
/build |
|
/build |
claudiolor
force-pushed
the
clo/make-tenant-optional
branch
from
393ccf8
to
a7c3a4d
Compare
claudiolor
force-pushed
the
clo/make-tenant-optional
branch
2 times, most recently
from
c0e175a
to
abd33b8
Compare
|
/test |
claudiolor
force-pushed
the
clo/make-tenant-optional
branch
from
abd33b8
to
c9668c8
Compare
aleoli
approved these changes
Oct 17, 2024
fra98
approved these changes
Oct 22, 2024
|
/rebase test=true |
When the CRDReplicator operator took in charge a secret, it did not look at its changes, so it was impossible to change the secret unless all the Offloading resources were deleting and the secret recreated. This patch fixes the reconciliation of the control plane secret so that when there is a change on the secret, even after it takes in charge reconciliation, it looks for differences and, if any, stops and restarts reconciliation with the new configuration.
This patch adds the possibility to create a Tenant without a key exchange with the peer cluster. This is useful when the user creates a secret on the consumer side with the kubeconfig to operate on the control plane.
…e times The remote ResourceSlice controller reconciled multiple times when the status of the resource was changed. To fix this issue this patch adds the GenerationChangedPredicate, allowing to reconcile only when the specs of the resource changes.
adamjensenbot
force-pushed
the
clo/make-tenant-optional
branch
from
c9668c8
to
9ecfa93
Compare
|
/test |
cheina97
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some use cases there might be the need to prepare the Liqo CR in advance and apply them once a peer needs to be created. However, because of the key exchange of the authentication module, doing so is not so trivial.
This PR addresses this issue by making the key exchange optional. However, in this case, the user is in charge of providing the kubeconfig with the right permission to be given to the cluster consumer.
This kubeconfig should be placed in a secret with labels:
and annotation:
On the provider side in the Tenant resource the
authzPolicyhas been created, whose role is determining the policy used by the cluster provider to authorize a ResourceSlice.KeysExchange, which means that the clusters needs to exchange their keys in advance.TolerateNoHandshakeno keys exchanges is performed, and the consumer is supposed to already have the permissions (a kubeconfig) to operate on the remote cluster.Additionally this PR introduces a couple of bug fixes:
How Has This Been Tested?
E2E tests will be added