Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have common issues make a copy of itself #106

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

zanerock
Copy link
Member

@zanerock zanerock commented Apr 4, 2023

Pull request to resolve #105

Submitted by: zanerock

Instructions

Review all code changes. Verify the submitter attestations belowe, checking off each statement to indicate that you have reviewed the statement and it is true to the best of your knowledge. If you do not agree with or are unsure of a statement, then add a comment describing your questions or concerns and contact the submitter @zanerock for clarification.

QA files

Submitter attestations

To be verified by reviewer.

  • Do the changes implement all concrete TODOs in the change ticket? y (CHANGES_IMPLEMENT_ALL_TODOS=true)
  • Are there other changes not described in the original work description? y (CHANGES_HAS_ADDITIONAL_CHANGES=true)
  • Are all additional changes non-behavior modifying? Allowed changes include: inline documentation, improving names, additional testing, updating existing dependencies, file organization and naming, and simple optimizations. y (CHANGES_ADDITIONAL_CHANGES_PERMITTED=true)
  • Have the additional changes been documented in the change ticket description under the Additional changes section? y (CHANGES_ADDITIONAL_CHANGES_DOCUMENTED=true)
  • Are there any QA exceptions which need to be addressed? n (CHANGES_HAS_QA_EXCEPTIONS=false)
  • Do the changes add or involve connections, authentication, or queries to a database or any third-party service? n (CHANGES_THIRD_PARTY_SERVICES_MODIFIED=false)
  • Has all debug, hard coded test data, and hard coded authentication data been removed? y (CHANGES_DEBUG_REMOVED=true)
  • I have reviewed and verified the above are true to the best of my knowledge.

@zanerock zanerock self-assigned this Apr 4, 2023
@zanerock zanerock added this to the 1.0.0-beta milestone Apr 4, 2023
@zanerock zanerock merged commit f3ed12c into main Apr 4, 2023
@zanerock zanerock deleted the work-liquid-labs/liq-work/105 branch April 4, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have common issues make a copy of itself
1 participant