Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "luna-tab-item"s don't display in Firefox #293

Closed
MasterInQuestion opened this issue Dec 9, 2022 · 7 comments
Closed

[Bug] "luna-tab-item"s don't display in Firefox #293

MasterInQuestion opened this issue Dec 9, 2022 · 7 comments

Comments

@MasterInQuestion
Copy link

    Tested Firefox 108.
    Regression introduced by Eruda v2.7.3.

    Likely related: #236

@surunzi
Copy link
Member

surunzi commented Dec 10, 2022

Use version 2.7.4 and see if it is fixed.

@MasterInQuestion
Copy link
Author

    Fixed in v2.7.4.

@surunzi surunzi closed this as completed Dec 10, 2022
@MasterInQuestion
Copy link
Author

    Firefox "document.body" is null error:
    I believe which shouldn't occur in current Firefox. [ https://caniuse.com/mdn-api_document_body ]

    Would you mind indicating the details causing the issue?

@surunzi
Copy link
Member

surunzi commented Dec 11, 2022

Not a firefox bug. The root cause is that firebox does not support custom scrollbar. In that case, luna-tab will try to access document.body before it is ready.

@MasterInQuestion
Copy link
Author

    Thanks.
    Would you mind indicating the change that resolves the issue?

@surunzi
Copy link
Member

surunzi commented Dec 11, 2022

liriliri/luna@4c9eac2

@MasterInQuestion
Copy link
Author

    Would you mind giving more debug info on how you located the problem?

    The diff you linked indicated the cause was "document.body"?
    Do you mean that in Firefox "document.body" would return null under certain conditions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants