Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent runs screw up log report #86

Open
CendioOssman opened this issue Nov 29, 2016 · 6 comments
Open

concurrent runs screw up log report #86

CendioOssman opened this issue Nov 29, 2016 · 6 comments

Comments

@CendioOssman
Copy link

Testing multiple browsers at the same time confuses the reporting somehow and you can't really see which instance failed or succeeded, or where the output belongs.

Examples:

https://travis-ci.org/CendioOssman/noVNC/jobs/179805509
https://travis-ci.org/CendioOssman/noVNC/jobs/179770987

@4kochi
Copy link
Collaborator

4kochi commented Nov 29, 2016

I am not sure if the output is from the reporter. Actually it supports concurrent browsers. Could it be that the output is from some console.log() statements?

@CendioOssman
Copy link
Author

Yes, it is. However I would expect that output to be either at the start or bottom, or at the test that generates the output. Right now it is very random.

More concerning is that:

a) there are tests that are marked as failed (red, and x), yet the entire run is considered a success
b) you cannot see the test results for each platform. So failures might just be for one platform, and a success might be skipped for others.

@4kochi
Copy link
Collaborator

4kochi commented Dec 9, 2016

Regarding the console.log this seems to be the same problem as in #78. There is also an open issue in the karma repo (karma-runner/karma#2342) which means this could be a general in how the reporters are supposed to use the logging API of karma. I will keep an eye on this

@4kochi
Copy link
Collaborator

4kochi commented Dec 9, 2016

The other problem with the different platforms is hard to track down for me. Might a problem which only occurs when using custom saucelab launchers. I will try to reproduce it.

@wesleycho
Copy link

This is a problem in karma itself IMO - karma is coupling the defining of default reporters with logging wired in, so reporters that are using the base reporter decorator are logging by default, which is probably not the intention. I have a proposed solution (karma-runner/karma#2342 (comment)) that I am leaning towards, and it would avoid needing to change anything in this library itself.

@4kochi
Copy link
Collaborator

4kochi commented Dec 14, 2016

Thanks for the information @wesleycho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants