Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow embedded runtime to be fully disabled #1082

Closed
josevalim opened this issue Apr 1, 2022 · 10 comments
Closed

Allow embedded runtime to be fully disabled #1082

josevalim opened this issue Apr 1, 2022 · 10 comments
Labels
area:backend Related to the backend feature New feature or request

Comments

@josevalim
Copy link
Contributor

For security concerns. Disabling should also be available via an environment variable.

@josevalim josevalim added feature New feature or request area:backend Related to the backend labels Apr 1, 2022
@jonatanklosko
Copy link
Member

Another option would be to have configuration for listing what runtime types should be available. By default we could even omit embedded altogether.

@josevalim
Copy link
Contributor Author

I think omitting embedded by default is good and then just a flag to turn it on. :)

@ByeongUkChoi
Copy link
Contributor

Do we need these environment variable like this LIVEBOOK_ENABLE_EMBEDDED_RUNTIME ​​here?
then, what if LIVEBOOK_DEFAULT_RUNTIME=embedded and LIVEBOOK_ENABLE_EMBEDDED_RUNTIME=false?

@josevalim
Copy link
Contributor Author

If it is disabled by default, then we don't need an env var, because the only use case we have so far is for Nerves and Nerves has its own config. So we just need something like config :livebook, :enable_embedded_runtime, true. :)

@jonatanklosko
Copy link
Member

@josevalim for nerves both Elixir and Mix standalone aren't useful, maybe instead we should allow config :livebook, :runtime_modules, [Livebook.Runtime.Embedded, Livebook.Runtime.Attached] ?

@josevalim
Copy link
Contributor Author

I like that as long as embedded is disabled by default! @ByeongUkChoi, Can you please revisit your PR?

@ByeongUkChoi
Copy link
Contributor

ByeongUkChoi commented Apr 3, 2022

that means, make config :livebook, :runtime_modules and check runtime module when select runtime type and connect runtime?

@josevalim
Copy link
Contributor Author

Yes!

@jonatanklosko
Copy link
Member

We can also dynamically for on the list of modules, so we match the configured order as well :)

@jonatanklosko
Copy link
Member

Closed via #1084.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the backend feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants