From 448a5508b4a764c7460f91be4383af9d31d5e9d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20K=C5=82osko?= Date: Fri, 14 Jun 2024 21:56:58 +0700 Subject: [PATCH] Fix Erlang documentation links --- lib/livebook/intellisense.ex | 2 +- test/livebook/intellisense_test.exs | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/livebook/intellisense.ex b/lib/livebook/intellisense.ex index 261b823a691..ec35a52921b 100644 --- a/lib/livebook/intellisense.ex +++ b/lib/livebook/intellisense.ex @@ -529,7 +529,7 @@ defmodule Livebook.Intellisense do end is_otp? = - case :code.which(app || module) do + case :code.which(module) do :preloaded -> true [_ | _] = path -> List.starts_with?(path, :code.lib_dir()) _ -> false diff --git a/test/livebook/intellisense_test.exs b/test/livebook/intellisense_test.exs index 57907735aa4..e23cfdda191 100644 --- a/test/livebook/intellisense_test.exs +++ b/test/livebook/intellisense_test.exs @@ -1574,6 +1574,11 @@ defmodule Livebook.IntellisenseTest do Intellisense.get_details(":atomics.new", 11, context, node()) assert content =~ ~r"https://www.erlang.org/doc/man/atomics.html#new-2" + + assert %{contents: [content]} = + Intellisense.get_details(":string.uppercase", 11, context, node()) + + assert content =~ ~r"https://www.erlang.org/doc/man/string.html#uppercase-1" end end