Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation mode difference fit is incorrect because CarbonXS does not load an input pattern #15

Closed
lktsui opened this issue Mar 14, 2017 · 0 comments
Assignees
Labels

Comments

@lktsui
Copy link
Owner

lktsui commented Mar 14, 2017

CarbonXS does not read in a dataset when running in calculation mode, so the output carbon.dat file does not include a set of source values to compare against.

Furthermore, the x-values may not match the currently loaded source file.

We should proceed as follows:

  • Read the x-fit, y-fit values from carbon.dat
  • Interpolate the y-fit values to the x-source values using linear interpolation
  • Subtract using the interpolated values
@lktsui lktsui added the bug label Mar 14, 2017
@lktsui lktsui self-assigned this Mar 14, 2017
@lktsui lktsui closed this as completed in dd8cc53 Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant