-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U# Compile error #191
Comments
Are you still experiencing this? |
I downloaded a fresh copy of this into a project with the latest World SDK and I get this error, yes. |
@lilithebowman could you try this branch please? |
Actually, since we have no installation instructions for the Dev Branch yet, I'll make a new branch based on the main branch for you to test. |
Wonderful! I can give that a try later. TYSM! |
Alright try this branch https://github.com/llealloo/vrc-udon-audio-link/tree/3-issue-master please |
|
@lilithebowman |
@float3 Good news! That worked. No more breaking console errors. Just runtime errors with the shader now. Strange. That's gonna likely be something on my side I assume? |
Oh yeah it's because I put it into the sub folder instead of just loading it into the root of /Assets, I see. (If I were designing this, I'd likely use referential links instead of absolute so people can do what they like with folders.) |
OK I assume you just have something in your project that makes |
I've opened a PR so the fix should be in the next release |
I changed all of the links in the shader files to referential links ( |
I don't know ¯\_(ツ)_/¯ |
I think there might be a reason why they used Absolute links |
Specify VRC.SDKBase.Utilities.IsValid to avoid possible ambiguity
There are pros and cons of both absolute and relative include paths. With absolute paths, you can move the shader anywhere without having to update it, but you are forced to have the included file in a set location. With relative paths, you cannot move the shader without also moving the included file, but you can move it. We found the former more desirable. |
U# scripts are producing compile errors when imported.
Other U# Scripts are works fine
Unity version: 2019.4.31f1
VRCSDK: 2022.06.03.00.03
U# Version: 0.20.3
AudioLink: 0.2.8
The text was updated successfully, but these errors were encountered: