Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support Playground 2.5 #2487

Closed
1 task done
PierrunoYT opened this issue Mar 9, 2024 · 5 comments · Fixed by #3073
Closed
1 task done

[Feature Request]: Support Playground 2.5 #2487

PierrunoYT opened this issue Mar 9, 2024 · 5 comments · Fixed by #3073
Labels
enhancement New feature or request

Comments

@PierrunoYT
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

Support Playground 2.5 Model

Proposed workflow

Choose the Playground 2.5 Model like the other models in Fooocus

Additional information

No response

@PierrunoYT PierrunoYT added enhancement New feature or request triage This needs an (initial) review labels Mar 9, 2024
@mashb1t
Copy link
Collaborator

mashb1t commented Mar 9, 2024

see #2395

@mashb1t mashb1t removed the triage This needs an (initial) review label Mar 9, 2024
@RandomGitUser321
Copy link

RandomGitUser321 commented Mar 16, 2024

Relevant:
It's now built into the diffusers library https://github.com/huggingface/diffusers/releases/tag/v0.27.0

EDMDPMSolverMultistepScheduler was added, so you don't need to implement anything special, just update diffusers to the latest and use it.

@mashb1t
Copy link
Collaborator

mashb1t commented Mar 16, 2024

@RandomGitUser321 thanks for the hint, but Fooocus doesn't use the diffuses package.

@RandomGitUser321
Copy link

@RandomGitUser321 thanks for the hint, but Fooocus doesn't use the diffuses package.

Ahh I see, you guys just implement it all manually, instead of using the library. Then again, probably makes it easier to inject tweaks into the mix. Well either way, the source on that scheduler is here if any brave soul(s) want to implement it:
https://github.com/huggingface/diffusers/blob/main/src/diffusers/schedulers/scheduling_edm_dpmsolver_multistep.py
Not sure how "worth it" it would be, seeing how this is pretty much the only model I know of that uses it.

@mashb1t
Copy link
Collaborator

mashb1t commented Jun 1, 2024

Implemented in #3073, please test CFG so we can find the best one for the preset (tested with 2 and 3, both with pro/contra9.

@mashb1t mashb1t closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants