Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New project "BOLT" joining the Monorepo #80

Open
ChristianKuehnel opened this issue Nov 3, 2021 · 7 comments
Open

New project "BOLT" joining the Monorepo #80

ChristianKuehnel opened this issue Nov 3, 2021 · 7 comments

Comments

@ChristianKuehnel
Copy link
Collaborator

I saw on the mailing list, that a new project "BOLT" shall be added to the LLVM monorepo:
https://lists.llvm.org/pipermail/llvm-dev/2021-November/153551.html

Some things to do:

  1. Update pre-merge checks Add support for BOLT in LLVM monorepo google/llvm-premerge-checks#364
  2. I would recommend adding some post-merge builds to cover the new project and the configurations you care about.
  3. It would probably make sense to add a new "Category" to Discourse. Please contact one of the admins for that.
@tru
Copy link

tru commented Nov 3, 2021

Might want a discord channel for it as well.

@ChristianKuehnel
Copy link
Collaborator Author

Update: Bolt is in the monorepo now.

@ChristianKuehnel
Copy link
Collaborator Author

from meeting 2022-01-18:

  • pre-merge testing is work in progress
  • @ChristianKuehnel reach out to Maksim Panchenko to understand if they need any help from the IWG. If not: close this issue.

@ChristianKuehnel
Copy link
Collaborator Author

from meeting on 2022-02-15:

  • enabled on pre-merge testing, is working
  • Christian pinged Maksim to see if there is anything we can do to help

@aaupov
Copy link

aaupov commented Feb 15, 2022

Hi @ChristianKuehnel,
One extra thing we need on in pre-merge testing is enable BOLT binary tests (bolt-tests).
For that, we need to clone an extra repository, pass extra CMake flags during configuration and run an extra check target.
Would it be possible to set it up?

On our end, we're in progress of reducing bolt-tests artifact size and moving it off Git LFS.

@ChristianKuehnel
Copy link
Collaborator Author

Everything's possible 😄
However we haven't had such a request so far. So we might have to figure out the right place to store/maintain scripting for that usecase. And maybe also make it generic, so that other sub-projects can hook up custom scripting as well...

@metaflow what do you think?

@ChristianKuehnel
Copy link
Collaborator Author

ping @metaflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants