Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users who don't provide a real covariance matrix? #101

Open
lebigot opened this issue Jul 30, 2019 · 2 comments
Open

Warn users who don't provide a real covariance matrix? #101

lebigot opened this issue Jul 30, 2019 · 2 comments

Comments

@lebigot
Copy link
Collaborator

lebigot commented Jul 30, 2019

No description provided.

@lebigot
Copy link
Collaborator Author

lebigot commented Jul 30, 2019

When defining numbers with uncertainty based on a covariance or correlation matrix, it could be useful to warn the user that the given matrix is not a valid one (for example, a 2x2 correlation matrix never has "large" non diagonal elements). Currently, the code does not complain when it gets an invalid matrix.

@ces42
Copy link

ces42 commented Aug 1, 2019

#103 affects some of this. The code in the pull request raises an error if the covariance/correlation matrices are not positive semidefinite (e. g. off-diagonal elements larger than one in the covariance matrix). Symmetry is not enforced since only the lower half of the matrices is read (I think this is probably the best option for this case?).
Also a correlation matrix is not forced to have ones on the diagonal, and if this isn't the case correlated_values_norm won't even return values with the prescribed uncertainty. IMO that last part should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants