Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUD-03: Provide recommendation for zero balance withdrawal response #232

Open
wbobeirne opened this issue Aug 21, 2023 · 1 comment
Open

Comments

@wbobeirne
Copy link

LUD-03 should provide an explicit recommendation for what to do if a requester has no amount they could withdraw. Right now someone could choose to implement this as:

  1. minWithdrawable and maxWithdrawable as 0
  2. Return an {"status": "ERROR"} error

While either approach should probably be handled from clients, it would be nice to have an expectation around this and reduce ambiguity.

As an aside, it might also be wise to specify that the *Withdrawable amounts should never be negative, unless there's a case for that that I'm not thinking of.

@wbobeirne wbobeirne changed the title Provide recommendation for zero balance withdrawal response LUD-03: Provide recommendation for zero balance withdrawal response Aug 21, 2023
@hsjoberg
Copy link
Collaborator

hsjoberg commented Aug 21, 2023

I think it makes sense to set min/maxWithdrawable to 0, instead of returning an error.

This would mean LUD-14 and LUD-19 are still discoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants