Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature implement get messages paginated and get labels #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature implement get messages paginated and get labels #34

wants to merge 2 commits into from

Conversation

Yanhenning
Copy link
Contributor

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Implemented the new method to get all messages with a given filter with pagination
  • Implemented a method to get the labels in an easy way
  • Fixes tests for GetMessages, the mock was leading into a false positive test

@Yanhenning Yanhenning self-assigned this Jan 8, 2024
@peril-loadsmart
Copy link

Warnings
⚠️

It looks like code was changed without adding anything to the Changelog.
If you are not sure whether this PR needs a changelog entry you may refer to this confluence page

Generated by 🚫 dangerJS

@Yanhenning Yanhenning marked this pull request as ready for review January 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelmax raelmax raelmax approved these changes

@doughss doughss doughss approved these changes

@lucastonelli lucastonelli lucastonelli approved these changes

Assignees

@Yanhenning Yanhenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yanhenning @raelmax @doughss @lucastonelli