-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: add session group manager #1055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 89.42% 91.54% +2.11%
==========================================
Files 170 175 +5
Lines 8207 8582 +375
Branches 953 1059 +106
==========================================
+ Hits 7339 7856 +517
+ Misses 868 726 -142 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外相关单测补一下
src/app/chat/features/SessionListContent/Modals/CreateGroupModal.tsx
Outdated
Show resolved
Hide resolved
src/app/chat/features/SessionListContent/Modals/ConfigGroupModal/index.tsx
Outdated
Show resolved
Hide resolved
之前阻止了modal中的默认点击事件: <div onClick={(e) => e.stopPropagation()}>
<Modal.....
</ div> 是因为弹窗也属于session Item,如果不阻止会出现以下情况(下方视频包含修改后-->修改前的对比): demo.mp4用文字描述就是在弹窗中点击也会触发切换当前会话的事件,看是否属于预期现象? |
感觉要阻止的 |
I feel like I need to stop it. Should this be put into the Modal component? |
fc254e5
to
206702d
Compare
需要用 div 包裹么 还是直接挂在弹窗也行? |
Does it need to be wrapped in a div or can it be hung directly in the pop-up window? |
@canisminor1990 之前试了是因为会报类型错误,Modal上没这个属性: |
这个逻辑有问题,导入的分组不存在时,应该自动创建这个分组。 |
There is a problem with this logic. When the imported group does not exist, this group should be automatically created. |
我估计 modal 应该在文档流里没有实体 div 节点,所以估计没法有这个事件。 |
I estimate that modal should not have entity div nodes in the document flow, so it is estimated that this event cannot occur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Great PR @canisminor1990 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 0.121.0](v0.120.6...v0.121.0) <sup>Released on **2024-01-24**</sup> #### ✨ Features - **misc**: Add session group manager. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add session group manager, closes [#1055](#1055) [#1045](#1045) [#1126](#1126) [#1120](#1120) ([e3281fc](e3281fc)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 0.121.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [Version 1.3.0](v1.2.5...v1.3.0) <sup>Released on **2024-01-24**</sup> #### ✨ Features - **misc**: Add session group manager. #### 🐛 Bug Fixes - **misc**: Fix default, fix rename. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add session group manager, closes [lobehub#1055](https://github.com/bentwnghk/lobe-chat/issues/1055) [lobehub#1045](https://github.com/bentwnghk/lobe-chat/issues/1045) [lobehub#1126](https://github.com/bentwnghk/lobe-chat/issues/1126) [lobehub#1120](https://github.com/bentwnghk/lobe-chat/issues/1120) ([e3281fc](e3281fc)) #### What's fixed * **misc**: Fix default ([82cbbde](82cbbde)) * **misc**: Fix rename ([5680bd7](5680bd7)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
## [Version 0.121.0](lobehub/lobe-chat@v0.120.6...v0.121.0) <sup>Released on **2024-01-24**</sup> #### ✨ Features - **misc**: Add session group manager. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add session group manager, closes [#1055](lobehub/lobe-chat#1055) [#1045](lobehub/lobe-chat#1045) [#1126](lobehub/lobe-chat#1126) [#1120](lobehub/lobe-chat#1120) ([e3281fc](lobehub/lobe-chat@e3281fc)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
在 #1045 的基础上:
@arvinxx @Justin3go
📝 补充信息 | Additional Information