Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency to OkHttp3 #2

Closed
evfool opened this issue Feb 26, 2019 · 6 comments
Closed

Upgrade dependency to OkHttp3 #2

evfool opened this issue Feb 26, 2019 · 6 comments

Comments

@evfool
Copy link

evfool commented Feb 26, 2019

the okHttp3 library used by this project is fairly old, would you accept a pull request with a working upgrade to okHttp3, released more than 3 years ago?

@rocainunwired
Copy link
Collaborator

This java-client is generated by using OpenAPI specifications & OpenAPI Generator. Pull request for this issue to this repo is not advisable as the library would be updated back with the okhttp3 library used by the generator when updates to specifications are made. But you could contribute to the OpenAPI generator repo and we'll pull the latest changes to the libraries from there.

@evfool
Copy link
Author

evfool commented Mar 29, 2019

OpenAPI Generator already has support (in beta state only though - https://github.com/OpenAPITools/openapi-generator/releases/tag/v4.0.0-beta2) to generate OkHttp3 bindings (okhttp generator defaults have been upgraded to okhttp3 from okhttp2 - OpenAPITools/openapi-generator#1897). Is there a way to request a java client generated with the new OpenAPI generator or to receive the files the client is generated from to do the generation myself?

@rocainunwired
Copy link
Collaborator

@evfool We'll push our spec file by tomorrow, and you could use it to generate the client directly with the OpenAPI version of your choice.

@rocainunwired rocainunwired reopened this Mar 29, 2019
@evfool
Copy link
Author

evfool commented Mar 29, 2019

Thank you, that will be very helpful.

@rocainunwired
Copy link
Collaborator

We have pushed our spec onto a new repo over here. You could use it to generate the client directly with the OpenAPI generator.

@evfool
Copy link
Author

evfool commented Apr 1, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants