Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastHttpUser: Show error codes on 'Failures' page for 'BadStatusCode' exception #1460

Closed
magupov opened this issue Jul 2, 2020 · 2 comments
Closed

FastHttpUser: Show error codes on 'Failures' page for 'BadStatusCode' exception #1460

magupov opened this issue Jul 2, 2020 · 2 comments
Labels
feature request

Comments

@magupov
Copy link
Contributor

magupov commented Jul 2, 2020

For FastHttpUser BadStatusCode is shown on Failuresweb page without status code which is not convenient

изображение

I suggest adding status code to the view, like that:

изображение

Basically, I have changes for that which I use locally. So I can make a PR if that feature looks good
@cyberw
Copy link
Collaborator

cyberw commented Jul 2, 2020

Sounds good!

@magupov magupov mentioned this issue Jul 4, 2020
Merged
@magupov
Copy link
Contributor Author

magupov commented Jul 4, 2020

Made a PR geventhttpclient/geventhttpclient#129

@magupov magupov closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyberw @magupov