Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After starting and then stopping a load test, master is updating state in a loop #1577

Closed
max-rocket-internet opened this issue Sep 29, 2020 · 2 comments · Fixed by #1580
Closed

After starting and then stopping a load test, master is updating state in a loop #1577

max-rocket-internet opened this issue Sep 29, 2020 · 2 comments · Fixed by #1580
Labels
bug

Comments

@max-rocket-internet
Copy link
Contributor

max-rocket-internet commented Sep 29, 2020 •
edited
Loading

After this PR: #1570

Then master is logging this repeatedly in a loop after stopping a load test:

[2020-09-29 15:15:40,859] locust-vps-master-746cf87dc7-rmws5/DEBUG/locust.runners: Updating state to stopped, old state was stopped

I will make a PR to fix.
@cyberw
Copy link
Collaborator

cyberw commented Sep 29, 2020

Wow, that is weird. Is it completely stuck, or just logging it a bunch of times before actually finishing?

@max-rocket-internet
Copy link
Contributor Author

Sorry, it's not stuck, everything works, but it's continually updating the state. Only visible with debug log level.

@max-rocket-internet max-rocket-internet mentioned this issue Sep 30, 2020
Merged
@cyberw cyberw added the invalid label Oct 12, 2020
@cyberw cyberw removed the invalid label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't log state change if it's the same
2 participants
@cyberw @max-rocket-internet