Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shutdown sequence to use plugin.stop #2

Closed
Tracked by #3963
jsvd opened this issue Sep 11, 2015 · 3 comments
Closed
Tracked by #3963

refactor shutdown sequence to use plugin.stop #2

jsvd opened this issue Sep 11, 2015 · 3 comments
Assignees
@untergeek
Labels
shutdown semantics

Comments

@jsvd
Copy link
Member

jsvd commented Sep 11, 2015

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895
@jsvd jsvd mentioned this issue Sep 11, 2015
Closed
43 tasks
@NickMRamirez
Copy link
Contributor

How does this apply? I only use teardown during shutdown of the plugin.

@jsvd jsvd self-assigned this Sep 11, 2015
@suyograo
Copy link

@NickMRamirez see elastic/logstash#3210 (comment) for details

@suyograo suyograo assigned untergeek and unassigned jsvd Sep 21, 2015
@untergeek
Copy link

There is no code here. This will be addressed in forks, or when something is merged here.

@jsvd jsvd mentioned this issue Sep 24, 2015
Open
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@untergeek untergeek

Labels
shutdown semantics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsvd @untergeek @suyograo @NickMRamirez