Add target option to jdbc input
#69
Conversation
…parameter is provided
andsel
changed the title
target option to jdbc input
lib/logstash/inputs/jdbc.rb
Outdated
|
|
||
| # target must be populated if ecs_compatibility is not :disabled | ||
| if @target.nil? && ecs_compatibility != :disabled | ||
| logger.warn("When ECS compatibility is enabled also target option must be valued") |
There was a problem hiding this comment.
believe we agreed upon this being logger at the info level (as a compromise since it might be legit to skip setting target in cases where data has no conflicts with the schema).
what I would be also interested, due other plugins, is a standard message we would use across plugins ... draft:
ECS compatibility is enabled but no ``target`` option was specified, it is recommended to set the option to avoid potential schema conflicts (if you're data is ECS compliant or non-conflicting feel free to ignore this message) // cc @yaauie @karenzone
There was a problem hiding this comment.
+1 on standardize, maybe we can put it as constant in the ECS mixin?
There was a problem hiding this comment.
@kares In another conversation for a different plugin, I believe we discussed emitting this as info, since it isn't exactly something that needs to be resolved.
There was a problem hiding this comment.
Can you recall maybe the plugin?So that I can use the same log info, to be consistent across various plugins
There was a problem hiding this comment.
believe we agreed upon this being logger at the
infolevel
yes we agreed on info level logging previously, we do not have another plugin with the "warning" yet.
that's why I proposed a message for review, if accepted we would use it here and maybe move to ECS support mixing for re-use (as @andsel suggested)? (it's going to concern 3 other plugins I can think of right away)
There was a problem hiding this comment.
| logger.warn("When ECS compatibility is enabled also target option must be valued") | |
| logger.info("ECS compatibility is enabled but no ``target`` option was specified, it is recommended to set the option to avoid potential schema conflicts (if you're data is ECS compliant or non-conflicting feel free to ignore this message)") |
There was a problem hiding this comment.
I think your message is perfect, in case of jdbc static and filter we would also add the id of the interested lookups, so in that case it could hit many lines like this, one for each lookup definition
Co-authored-by: kaisecheng <[email protected]>
Co-authored-by: Karol Bucek <[email protected]>
Co-authored-by: Karol Bucek <[email protected]>
andsel
force-pushed
the
feature/enable_ecs_for_jdbc_input
branch
from
eb17aef
to
7d58fbe
Compare
This PR adds the
targetoption to configure destination field inside the event to the JDBC input.When ECS is enabled and the
targetis not specified it log a warn message.Related #19