Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import mysql connector using lerna import #1726

Closed
3 tasks
dhmlau opened this issue Sep 18, 2018 · 2 comments
Closed
3 tasks

Import mysql connector using lerna import #1726

dhmlau opened this issue Sep 18, 2018 · 2 comments

Comments

@dhmlau
Copy link
Member

dhmlau commented Sep 18, 2018

Part of #890 epic

IMPORTANT
Keep the amount of changes made in the actual code as little as possible. Not allowed: changes in the way how connector works (functionality/behavior/API), how the code is structured or formatted.

If the imported code does not pass code linting and/or prettier formatting rules, then changes to make the code compliant must be done in a standalone commit.

Acceptance Criteria

Using the same monorepo created in ##1725

  • import loopback-connector-mysql using lerna import
  • Set up Travis for CI - how to test and build using Travis
  • find a way and document how to build and test locally
    • set up db using docker

Reference

See more detailed discussion: #890

@stale
Copy link

stale bot commented Nov 8, 2019

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Nov 8, 2019
@stale
Copy link

stale bot commented Dec 8, 2019

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant