Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test relations against databases #3442

Closed
5 tasks
bajtos opened this issue Jul 26, 2019 · 0 comments · Fixed by #3538
Closed
5 tasks

Test relations against databases #3442

bajtos opened this issue Jul 26, 2019 · 0 comments · Fixed by #3538
Assignees
@nabdelgadir @agnes512
Labels
feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package
Milestone
Aug 2019 milestone

Comments

@bajtos
Copy link
Member

bajtos commented Jul 26, 2019 •
edited by agnes512
Loading

Refactor existing integration & acceptance tests for relations, move most (or
all) of them to repository-tests package.

I am not sure how much work will be required to make these tests pass against MongoDB (coercion between ObjectID vs. string). If it would require non-trivial amount of time, then:

  • Introduce one or more new CrudFeature flags allowing MongoDB test suite to skip these new tests.
  • Open a follow-up issue to investigate & fix the MongoDB test suite later.

See also #3387, and here.

Acceptance criteria

Tests to review & move:
@bajtos bajtos added feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package 2019Q3 labels Jul 26, 2019
This was referenced Jul 26, 2019
Closed
Closed
@dhmlau dhmlau mentioned this issue Jul 26, 2019
Closed
20 tasks
@bajtos bajtos added the p1 label Jul 26, 2019
@agnes512 agnes512 mentioned this issue Jul 31, 2019
Closed
32 tasks
@nabdelgadir nabdelgadir added this to the Aug 2019 milestone milestone Jul 31, 2019
@agnes512 agnes512 mentioned this issue Aug 12, 2019
Merged
7 tasks
@bajtos bajtos mentioned this issue Aug 23, 2019
Closed
7 tasks
@dhmlau dhmlau added the Slipped label Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nabdelgadir nabdelgadir

@agnes512 agnes512

Labels
feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package
Projects
None yet
Milestone
Aug 2019 milestone
Development

Successfully merging a pull request may close this issue.

refactor(repository-tests): move relation tests to repository-tests package loopbackio/loopback-next
4 participants
@bajtos @dhmlau @nabdelgadir @agnes512