Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement InclusionResolver for hasMany relation #3447

Closed
3 of 5 tasks
bajtos opened this issue Jul 26, 2019 · 0 comments · Fixed by #3595
Closed
3 of 5 tasks

Implement InclusionResolver for hasMany relation #3447

bajtos opened this issue Jul 26, 2019 · 0 comments · Fixed by #3595
Assignees
@nabdelgadir @agnes512
Labels
feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package
Milestone
Sept 2019 milestone

Comments

@bajtos
Copy link
Member

bajtos commented Jul 26, 2019 •
edited by agnes512
Loading

Acceptance criteria

  • Implement a factory function for creating an inclusion resolver for the given hasMany relation (see createHasManyInclusionResolver in the spike - RFC: Resolver for inclusion of related models #3387, and here)
  • Enhance HasManyRepositoryFactory to provide resolver property (see the spike).
  • Write integration-level tests in packages/repository-tests to verify that resolver works for real databases.
  • Feel free to write unit-level tests using mocked repositories too, as needed.
  • Update documentation (e.g. Configuring a hasMany relation to explain how to enable or disable inclusion. Include examples showing how to build a query to include related model(s).
@bajtos bajtos added feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package 2019Q3 labels Jul 26, 2019
This was referenced Jul 26, 2019
Closed
Closed
@dhmlau dhmlau mentioned this issue Jul 26, 2019
Closed
20 tasks
@bajtos bajtos added the p1 label Jul 26, 2019
@agnes512 agnes512 mentioned this issue Jul 31, 2019
Closed
32 tasks
This was referenced Aug 28, 2019
Merged
Closed
@dhmlau dhmlau added this to the Sept 2019 milestone milestone Sep 3, 2019
@agnes512 agnes512 mentioned this issue Sep 13, 2019
Merged
7 tasks
@dhmlau dhmlau mentioned this issue Sep 23, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nabdelgadir nabdelgadir

@agnes512 agnes512

Labels
feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package
Projects
None yet
Milestone
Sept 2019 milestone
Development

Successfully merging a pull request may close this issue.

feat(repository): implement inclusionResolver for hasMany relation loopbackio/loopback-next
4 participants
@bajtos @dhmlau @nabdelgadir @agnes512