Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community authorization example to our doc #5595

Closed
2 tasks
HrithikMittal opened this issue May 28, 2020 · 2 comments · Fixed by #6599
Closed
2 tasks

Add community authorization example to our doc #5595

HrithikMittal opened this issue May 28, 2020 · 2 comments · Fixed by #6599

Comments

@HrithikMittal
Copy link
Contributor

HrithikMittal commented May 28, 2020

Suggestion

I know you already create docs for adding the Authorization in loopback4 using the shopping example. But for developers to understand is tough (for me also previously as there are some bugs into also- in docs.)

In continuation of these issues
#5573
#5294
#5441

Use Cases

So, again as I already create a one for Authentication similar way I create a repo with the Readme file where a complete processor and steps are mentions of implementing the Authorization is given. [Repo link: https://github.com/HrithikMittal/Loopback4-authorization ]

I just give a bit of advice, If you can add the repo into yours or just add Readme would be beneficial for other developers.

Examples

Authorization
https://github.com/HrithikMittal/Loopback4-authorization

Acceptance criteria

@dhmlau
Copy link
Member

dhmlau commented May 28, 2020

@jannyHou, you've proposed a plan on improving the docs for authentication (issue #5294), could you please take a look at this for authorization as well? Similarly, we can make this as an epic, if there's no duplicate issues already, and break it down into sub-tasks. Thanks!

@dhmlau dhmlau added the 2020Q3 label May 28, 2020
@jannyHou jannyHou changed the title Loopback4 Authorization Add community authorization example to our doc Jul 27, 2020
@dhmlau dhmlau removed the 2020Q3 label Sep 11, 2020
@dhmlau
Copy link
Member

dhmlau commented Oct 18, 2020

@HrithikMittal, I just created a community example page. I believe we can just add your example repo to that page. Are you interested to submit a PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants