Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce getModelSchema and soft-deprecate getModelSchemaRef #5791

Open
dhmlau opened this issue Jun 20, 2020 · 0 comments
Open

Introduce getModelSchema and soft-deprecate getModelSchemaRef #5791

dhmlau opened this issue Jun 20, 2020 · 0 comments

Comments

@dhmlau
Copy link
Member

dhmlau commented Jun 20, 2020

Opening a follow up issue according to: #4328 (comment)

Cross posting @bajtos' comment from the above link:


After we land feat(rest): add openapi schema consolidation #4365, I'd like to start the process of deprecating getModelSchemaRef and reworking both our existing code and CLI templates to leverage the new schema consolidation:

  • Introduce getModelSchema similar to getModelSchemaRef (see src/controller-spec.ts)
  • Rework our controller templates to use getModelSchema instead of getModelSchemaRef
  • Rework controllers inside /examples to use getModelSchema
  • Soft-deprecate getModelSchemaRef in our documentation (both /docs files and the tsdoc comment)
  • Update https://github.com/strongloop/loopback4-example-shopping to use getModelSchema

cc @bajtos @jannyHou

@stale stale bot added the stale label Dec 25, 2020
@achrinza achrinza removed the stale label Apr 17, 2021
@stale stale bot added the stale label Oct 14, 2021
@stale stale bot closed this as completed Nov 13, 2021
@achrinza achrinza reopened this Nov 20, 2021
@stale stale bot removed the stale label Nov 20, 2021
@loopbackio loopbackio deleted a comment from stale bot Nov 20, 2021
@loopbackio loopbackio deleted a comment from stale bot Nov 20, 2021
@loopbackio loopbackio deleted a comment from stale bot Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants