Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More issues with field names with dots in them #24

Open
mpalmer opened this issue May 20, 2016 · 2 comments
Open

More issues with field names with dots in them #24

mpalmer opened this issue May 20, 2016 · 2 comments

Comments

@mpalmer
Copy link

mpalmer commented May 20, 2016

Certain ill-mannered programs (I'm looking at you, docker-registry) emit JSON-formatted log entries, but use dot-delimited nesting in the key names, which breaks with ES 2.x. Since the JSON emitted by these programs isn't necessarily intended to be consumed by logstash, it's not necessarily their fault that they're producing logstash-incompatible JSON, but is instead logspout-logstash's responsibility to transmute the error-producing JSON into something that logstash will understand.

I can think of two options:

  1. Replace all dots in keys with underscores (quick, dirty, and within my extremely limited Go skills to implement); or
  2. Translate dot-encoded keys into a nested structure (far superior, but there's no way known I can implement that all by myself).

Would a PR to implement option 1 be merged, or should I wait for someone with better Go chops to implement 2?

@maxekman
Copy link
Member

Hey, sorry for not responding sooner. Is this still an issue for you? Which solution would you prefer as a fix in that case?

@mpalmer
Copy link
Author

mpalmer commented Aug 30, 2016

Yes, it's still an issue. Option 2 would be a better outcome, by far, because it maintains structure, but someone else would have to implement it because I've got near-zero Go skills. I could do a PR for option 1, though, if nobody else has the time to code something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants