Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: link to the hosted version #36

Open
Bekt opened this issue Oct 6, 2016 · 5 comments
Open

Q: link to the hosted version #36

Bekt opened this issue Oct 6, 2016 · 5 comments
Labels

Comments

@Bekt
Copy link

Bekt commented Oct 6, 2016

Hello, this adapter is great! I'm maintaining a hosted version of this at Bekt/logspout-logstash on Docker Hub. I was wondering if you could link to it somewhere in this project.

@maxekman
Copy link
Member

maxekman commented Oct 6, 2016

Hi, and thanks! Cool that you have made a ready to run container. What do you think about contributing it directly into this repo?

@Bekt
Copy link
Author

Bekt commented Oct 6, 2016

That is fine with me as long as you guys can maintain it -- basically keep the build.sh file updated with the gliderlabs/logspout:master. I published this about a month ago and it seems to already have 1k downloads (not sure if real or bots), so that's another issue.

@maxekman
Copy link
Member

maxekman commented Oct 6, 2016

Definitely! Would it be possible for you to make a PR with a docker folder containing the related files and append the contents of your readme to a new section (but maybe keep the badges at the top)? I'll add testing and code coverage soon to join your docker badges. 😊

Don't forget to credit yourself in the Docker section in the readme if you want!

@Bekt
Copy link
Author

Bekt commented Dec 2, 2016

Just an update: I still want/have plans to do this, I just haven't had the time.

Just to make sure: do you want to host this on your DockerHub or would like to keep it on mine? I can give you/others access, I just don't any breaking changes for others (currently at 36k downloads). Would like to hear what would be the best for you guys since you're basically taking over.

@maxekman
Copy link
Member

Hi, sorry for the delay. We can host it on our account. Maybe you can add a note on your repo that it is not maintained and point to the new location?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants