Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New actions fail on repo with fork #98

Closed
lorenzwalthert opened this issue Jan 14, 2022 · 10 comments · Fixed by #99
Closed

New actions fail on repo with fork #98

lorenzwalthert opened this issue Jan 14, 2022 · 10 comments · Fixed by #99
Assignees
Labels
bug Something isn't working

Comments

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Jan 14, 2022

In {styler}, I can't seem to make the action pass after replacing the Workflows with the templates from {touchstone}:
https://github.com/r-lib/styler/actions/runs/1699543116

Any idea why? There is a corresponding PR that shows passing but the comment from {touchstone} is missing. From the error message, it seems like the secrets context is missing.

@assignUser
Copy link
Collaborator

I think we have to pass the token into the action explicitly (No idea why it worked during my tests...). I will create a quick patch for main.

@assignUser assignUser added the bug Something isn't working label Jan 14, 2022
@assignUser assignUser self-assigned this Jan 14, 2022
@lorenzwalthert
Copy link
Owner Author

lorenzwalthert commented Jan 15, 2022

Thanks @assignUser. With #99, still no luck. Now seems an unrelated {pak} problem. https://github.com/r-lib/styler/runs/4828086477?check_suite_focus=true.

@assignUser
Copy link
Collaborator

assignUser commented Jan 15, 2022 via email

@lorenzwalthert
Copy link
Owner Author

ok, will try re-run.

@assignUser
Copy link
Collaborator

r-lib/actions#483

@lorenzwalthert
Copy link
Owner Author

lorenzwalthert commented Jan 15, 2022

Thanks for the issue 👍 .

@lorenzwalthert
Copy link
Owner Author

And it failed again https://github.com/r-lib/styler/runs/4828631586?check_suite_focus=true... Hope this can be fixed or it's just by chance.

@assignUser
Copy link
Collaborator

Ugh, that's annoying... I think it's by chance maybe some request times out? They are using RSPM for dependency resolution afaik so maybe somethings spotty there? I'll add that run to the issue.

@assignUser
Copy link
Collaborator

It works! 🎉 r-lib/styler#868 (comment)

@lorenzwalthert
Copy link
Owner Author

Indeed, it did 🥳. Let's see how it goes with the {pak} error in the future. I previously started using a more recent RSPM as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants