-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference between timeout
and open_timeout
#1469
Comments
Hi @Yu-Chieh-Henry-Yang, apologies if this is confusing.
OTOH |
You're right though the description for |
There are 2 more types of timeout, I've added a comment to explain them all to your PR 👍 |
Thanks for the explanation @iMacTia , I will continue the conversation in my PR. 🙏 |
We have these comment in the codebase:
faraday/lib/faraday/options/env.rb
Lines 18 to 19 in 1a5b794
:timeout
saysopen/read timeout Integer in seconds
:open_timeout
saysread timeout Integer in seconds
Question 1: Does this mean
timeout
includesopen_timeout
? For example, if everything times out at the limit and we configured to have 4 secondsopen_timeout
and 6 secondstimeout
, do we actually wait only 6 seconds (which includes the 4 seconds) or do we actually wait 4+6 = 10 seconds?Question 2:
:open_timeout
is called "open" timeout, why does it saysread timeout Integer in seconds
instead of something liketimeout Integer in seconds for opening connection
?Thank you very much.
The text was updated successfully, but these errors were encountered: