Show external links for media #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crxssed7
commented
Jun 24, 2023
crxssed7
changed the title
lotusprey
requested changes
Jun 24, 2023
lotusprey
requested changes
Jun 24, 2023
lotusprey
approved these changes
Jun 24, 2023
|
Thanks for the contribution :) |
lotusprey
added a commit
that referenced
this pull request
Oct 15, 2023
* Show external links for media (#86) * Initial work for external links * Lint and use Container for all scroll cards * Small tidy up for external links * Remove named parameter * Move fields under constructor for ExternalLink * Move external link color to its own Container * Small Lint --------- Co-authored-by: lotusgate <[email protected]> * Improved settings and horizontal chip lists * Better button row on user pages and cleanup * Improved switcher widgets and other visual elements * Code cleanup and padding improvements * Improved external link sorting, and bar chart sizing * Added language identification on external media links * Fixed media external link sorting * Maintenance * Reorganised discover logic * Modified searching logic * Added site links to character/staff/studio pages * Fixed notification icon and feed badge * Changed handling of certain padding * Fixed padding and bottom bar layouts * Updated versioning * Fixed settings spacing * Updated screenshots * Updated dependencies and fixed visual/lazy-loading bugs * Fixed activity page padding * Fixed and restructuring * Finished calendar and restructured some files * Pure theme option now not only makes dark themes black, but light themes white * Support more languages in the external links * Fastlane setup * Updated dependencies and other cleanup * Versioning and calendar fixes * Fixed null exceptions * Calendar filters are cached * Made calendar date selection more flexible --------- Co-authored-by: Tanveer Najib <[email protected]> Co-authored-by: lotusgate <[email protected]>
lotusprey
added a commit
that referenced
this pull request
Jan 8, 2024
* Show external links for media (#86) * Initial work for external links * Lint and use Container for all scroll cards * Small tidy up for external links * Remove named parameter * Move fields under constructor for ExternalLink * Move external link color to its own Container * Small Lint --------- Co-authored-by: lotusgate <[email protected]> * Improved settings and horizontal chip lists * Better button row on user pages and cleanup * Improved switcher widgets and other visual elements * Code cleanup and padding improvements * Improved external link sorting, and bar chart sizing * Added language identification on external media links * Fixed media external link sorting * Maintenance * Reorganised discover logic * Modified searching logic * Added site links to character/staff/studio pages * Fixed notification icon and feed badge * Changed handling of certain padding * Fixed padding and bottom bar layouts * Updated versioning * Fixed settings spacing * Updated screenshots * Updated dependencies and fixed visual/lazy-loading bugs * Fixed activity page padding * Fixed and restructuring * Finished calendar and restructured some files * Pure theme option now not only makes dark themes black, but light themes white * Support more languages in the external links * Fastlane setup * Updated dependencies and other cleanup * Versioning and calendar fixes * Fixed null exceptions * Calendar filters are cached * Made calendar date selection more flexible * Minor touch ups and updated dependencies. * Improved html rendering * Render HTML description preview (#113) * Render HTML description preview Fixes #108 * Replaced navigation and authentication deep linking with go_router (#114) * Replaced old routing method with go_router * Authentication deep linking is now done with go_router * Fixed merging * Fixed pie chart labels and media date displaying Pie charts in user statistics had incorrect labels Incomplete dates were displayed incorrectly in media pages * Add option to search in notes (#116) Cool, thanks :) * Add comment reply button (#118) * Add comment reply button * Reorganized files and updated dependencies * Clean up of some deep links * Images open as pop ups and mentions work in HTML content * Better account handling * Deep linking on android * Confirmed IOS https deep linking as currently impossible * Fix AniList settings not updating * Adjustments in how score is represented * Fix text padding in bar charts * Tapping a media ranking redirects to discover * Fix settings updating when page is closed * More cohesive button & chip design * Add list status for related media in the media page * Updated version * Update ios target version * Clear comments --------- Co-authored-by: Tanveer Najib <[email protected]> Co-authored-by: lotusgate <[email protected]> Co-authored-by: Nils Strelow <[email protected]> Co-authored-by: Daniel Scherf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new section on the media info view for external links (closes #62):
