Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTML Auth required workstation number, but should not be required #1766

Closed
2 tasks done
christopherpickering opened this issue Jun 14, 2022 · 0 comments · Fixed by #1767 or #1768
Closed
2 tasks done

NTML Auth required workstation number, but should not be required #1766

christopherpickering opened this issue Jun 14, 2022 · 0 comments · Fixed by #1767 or #1768
Labels
bug Something isn't working

Comments

@christopherpickering
Copy link
Contributor

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

Patch for #1639 in alpha.

If workstation is left blank a null value should not be passed to axios-ntlm.

👟 Reproduction steps

Pass a blank workstation number to ntlm auth

👀 Expected behavior

It is ok to have a blank workstation.

Also, workstation number should not be a password field.

😓 Actual Behavior

"Cannot read property 'length' of null".

🐻 Uptime-Kuma Version

1.17.0-Alpha

💻 Operating System and Arch

Ubuntu 20, MacOs

🌐 Browser

Safari

🐋 Docker Version

No response

🟩 NodeJS Version

Latest

📝 Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant