Use navigator.languages instead of navigator.language for language detection

[cyberbellum96]

⚠️ Please verify that this bug has NOT been raised before.

• I checked and didn't find similar issue

🛡️ Security Policy

• I agree to have read this project Security Policy

📝 Describe your problem (edited by @chaflying)

Language key uk is not recognized by the front-end, and the displayed language defaults back to en.

📝 Error Message(s) or Log

No response

🐻 Uptime-Kuma Version

1.23.10

💻 Operating System and Arch

Ubuntu 22.04.3 LTS

🌐 Browser

N/A

🐋 Docker Version

24.0.7

🟩 NodeJS Version

N/A

[CommanderStorm]

What do you mean by "for editing"? you have found the correct folder for editing the database

[cyberbellum96]

What do you mean by "for editing"? you have found the correct folder for editing the database

I need to change some status page data, but I can't find its source code. I already asked a question about changing the language on the status page. Now I need to find a file where I can edit the default language for site visitors.

[CommanderStorm]

First of all, it seems like you are using docker.
Note that modifications to this part would be temporary and revert at the next reboot.

A default language and locale switcher is included in #3523 and said PR will be reviewed in the v2.1 release train.

See #1643
=> there is no "default language" for site visitors, this is dependent on which language the OS is set to.

Localising the footer/.. is tracked here: #2784

Our contibution guide (including how to get a dev environment set up) is here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

[cyberbellum96]

First of all, it seems like you are using docker. Note that modifications to this part would be temporary and revert at the next reboot.

A default language and locale switcher is included in #3523 and said PR will be reviewed in the v2.1 release train.

See #1643 => there is no "default language" for site visitors, this is dependent on which language the OS is set to.

Localising the footer/.. is tracked here: #2784

Our contibution guide (including how to get a dev environment set up) is here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

I have "Ukrainian" in my OS settings, but by default it displays in English.

[CommanderStorm]

The default language is determined like this:

uptime-kuma/src/i18n.js

Lines 60 to 63 in 8151ac0

	export const currentLocale = () => localStorage.locale
	|| languageList[navigator.language] && navigator.language
	|| languageList[navigator.language.substring(0, 2)] && navigator.language.substring(0, 2)
	|| "en";

Could you run the following commands in the console with uptime open?

localStorage.locale

navigator.language

[cyberbellum96]

The default language is determined like this:

uptime-kuma/src/i18n.js

Lines 60 to 63 in 8151ac0

	export const currentLocale = () => localStorage.locale
	|| languageList[navigator.language] && navigator.language
	|| languageList[navigator.language.substring(0, 2)] && navigator.language.substring(0, 2)
	|| "en";

The problem is that I can't find where this file is located: uptime-kuma/src/i18n.js

Could you run the following commands in the console with uptime open?

localStorage.locale

navigator.language

How exactly should I execute these commands through the console?

[cyberbellum96]

I managed to find 3 i18n.js files at the following address: var/lib/docker/overlay2/[many numbers and letters]/diff/app/src

[CommanderStorm]

How exactly should I execute these commands through the console?

The console is integrated into your browser (assuming you use chrome given that you did not fill out that field). Open the the inspector via right-clicking

and then

[cyberbellum96]

It should be in Ukrainian, but it is displayed in English.

[CommanderStorm]

The reason for this is that we currently only support the uk-UA locale and not uk

I think a better approach compared to the current one would be to use the following instead:

Docs: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/languages

[cyberbellum96]

Okay, I understand what the problem is. Thank you very much!

[CommanderStorm]

Closing as #4244 was merged