Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification auto disabling on clicking save.button #5206

Closed
1 task done
ro7it opened this issue Oct 16, 2024 · 3 comments Β· Fixed by #5196
Closed
1 task done

Notification auto disabling on clicking save.button #5206

ro7it opened this issue Oct 16, 2024 · 3 comments Β· Fixed by #5196
Labels
bug Something isn't working

Comments

@ro7it
Copy link

ro7it commented Oct 16, 2024

πŸ“‘ I have found these related issues/pull requests

Notification auto disabling on clicking save.button

πŸ›‘οΈ Security Policy

Description

image

πŸ‘Ÿ Reproduction steps

Try to add a monitor and then enable the notification after adding a suitable channel like Slack. When clicking on save, it gets auto-disabled.

πŸ‘€ Expected behavior

It should be Enabled only when enabling and disabled when disabling.

πŸ˜“ Actual Behavior

Getting auto disabled on enabling and saving the changes.

🐻 Uptime-Kuma Version

latest

πŸ’» Operating System and Arch

M1

🌐 Browser

Chrom and Mozilla

πŸ–₯️ Deployment Environment

  • Runtime: default
  • Database: default
  • Filesystem used to store the database on: default on local
  • number of monitors: 2

πŸ“ Relevant log output

Nothing found in logs.
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Oct 16, 2024

auto disabling

They were just displayed wrong, no need to be concearned.

Also for the future please make sure to include that you are running the pre-beta version (v2.0-dev) of the software

@ro7it
Copy link
Author

ro7it commented Oct 16, 2024

Just took a latest pull and build and testing, seeing issue with notification.

2024-10-16T17:53:24+05:30 [MANAGE] INFO: Resume Monitor: 1 User ID: 1
2024-10-16T17:53:24+05:30 [MONITOR] ERROR: Cannot send notification to Superman
2024-10-16T17:53:24+05:30 [MONITOR] ERROR: Error: Error: TypeError: this.extractAddress is not a function
at Slack.throwGeneralAxiosError (/Users/rohitti/Downloads/demo-app/server/notification-providers/notification-provider.js:69:15)
at Slack.send (/Users/rohitti/Downloads/demo-app/server/notification-providers/slack.js:167:18)
at async Monitor.sendNotification (/Users/rohitti/Downloads/demo-app/server/model/monitor.js:1340:21)
at async beat (/Users/rohitti/Downloads/demo-app/server/model/monitor.js:922:21)
at async safeBeat (/Users/rohitti/Downloads/demo-app/server/model/monitor.js:1007:17)

@CommanderStorm
Copy link
Collaborator

Thanks for testing ^^
That was fixed in #5209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants